Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552073002: Fix proto_java_library comment example (Closed)

Created:
4 years, 11 months ago by Daniel Imms
Modified:
4 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix proto_java_library comment example proto_path is a string not an array. BUG=NONE Committed: https://crrev.com/24ad7029705b271d0a12107231a1db5f4d5abb6d Cr-Commit-Position: refs/heads/master@{#367319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/android/rules.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Daniel Imms
PTAL
4 years, 11 months ago (2015-12-31 18:52:40 UTC) #2
agrieve
On 2015/12/31 18:52:40, Daniel Imms wrote: > PTAL lgtm
4 years, 11 months ago (2016-01-04 16:09:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552073002/1
4 years, 11 months ago (2016-01-04 16:12:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 16:57:20 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 16:58:28 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/24ad7029705b271d0a12107231a1db5f4d5abb6d
Cr-Commit-Position: refs/heads/master@{#367319}

Powered by Google App Engine
This is Rietveld 408576698