Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552023002: Convert Pass()→std::move() in //components (CrOS edition) (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
chirantan+watch_chromium.org, chromium-reviews, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //components (CrOS edition) (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=caitkp@chromium.org Committed: https://crrev.com/dc5f124021b338adc8caa533583eab97813558fe Cr-Commit-Position: refs/heads/master@{#367228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -53 lines) Patch
M components/drive/change_list_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/change_list_processor_unittest.cc View 18 chunks +28 lines, -28 lines 0 comments Download
M components/drive/directory_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/file_system_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ownership/owner_key_util.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/ownership/owner_key_util_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ownership/owner_settings_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/pairing/bluetooth_controller_pairing_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/pairing/shark_connection_listener.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/policy/core/common/proxy_policy_provider.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M components/policy/core/common/proxy_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/rlz/rlz_tracker.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_chromeos_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/timers/alarm_timer_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/user_manager/user_manager_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/wifi_sync/wifi_credential_syncable_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/wifi_sync/wifi_credential_syncable_service_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for general review / sanity check +caitkp for owners review
4 years, 11 months ago (2015-12-31 01:14:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552023002/1
4 years, 11 months ago (2015-12-31 01:15:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-31 02:06:43 UTC) #5
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-31 04:49:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552023002/1
4 years, 11 months ago (2015-12-31 04:50:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 04:54:59 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 04:56:12 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc5f124021b338adc8caa533583eab97813558fe
Cr-Commit-Position: refs/heads/master@{#367228}

Powered by Google App Engine
This is Rietveld 408576698