Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1551963002: Fix -Wunused-function warnings in android/asan builds. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix -Wunused-function warnings in android/asan builds. BUG=chromium:573250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/client/linux/handler/exception_handler_unittest.cc View 4 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
If you like it, please land it.
4 years, 11 months ago (2015-12-30 22:12:01 UTC) #2
Lei Zhang
lgtm, but I don't get the Android reference.
4 years, 11 months ago (2015-12-30 23:39:48 UTC) #3
Lei Zhang
On 2015/12/30 23:39:48, Lei Zhang wrote: > lgtm, but I don't get the Android reference. ...
4 years, 11 months ago (2015-12-30 23:41:49 UTC) #4
Lei Zhang
On 2015/12/30 22:12:01, Nico wrote: > If you like it, please land it. Landed in ...
4 years, 11 months ago (2015-12-30 23:44:21 UTC) #5
Nico
4 years, 11 months ago (2015-12-30 23:51:53 UTC) #7
Message was sent while issue was closed. 
On 2015/12/30 23:41:49, Lei Zhang wrote:
> On 2015/12/30 23:39:48, Lei Zhang wrote:
> > lgtm, but I don't get the Android reference.
> 
> Oh, because android_clang_dbg_recipe is building with ASAN?

Yes. Not sure why the Linux asan bot was happy, guess it doesn't build this
file. Thanks for landing!

Powered by Google App Engine
This is Rietveld 408576698