Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1551863002: Port android_aapt_path, app_as_shared_lib and alternative_sdk to GN (Closed)

Created:
4 years, 11 months ago by michaelbai
Modified:
4 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port android_aapt_path, app_as_shared_lib and alternative_sdk to GN alternative_sdk_jar is used in proguard BUG=565532 Committed: https://crrev.com/fd78509dac4927f0406a0947a18c5b15fb0862ee Cr-Commit-Position: refs/heads/master@{#367172}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -9 lines) Patch
M build/config/android/internal_rules.gni View 10 chunks +46 lines, -7 lines 0 comments Download
M build/config/android/rules.gni View 1 2 7 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
michaelbai
4 years, 11 months ago (2015-12-30 00:14:02 UTC) #3
agrieve
lgtm https://codereview.chromium.org/1551863002/diff/20001/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1551863002/diff/20001/build/config/android/rules.gni#newcode582 build/config/android/rules.gni:582: # nit: Remove blank line (feel free to ...
4 years, 11 months ago (2015-12-30 15:12:16 UTC) #4
michaelbai
https://codereview.chromium.org/1551863002/diff/20001/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1551863002/diff/20001/build/config/android/rules.gni#newcode582 build/config/android/rules.gni:582: # On 2015/12/30 15:12:16, agrieve wrote: > nit: Remove ...
4 years, 11 months ago (2015-12-30 18:54:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551863002/40001
4 years, 11 months ago (2015-12-30 18:55:43 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2015-12-30 19:27:44 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 19:28:40 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fd78509dac4927f0406a0947a18c5b15fb0862ee
Cr-Commit-Position: refs/heads/master@{#367172}

Powered by Google App Engine
This is Rietveld 408576698