[Chromecast] Add BindToTaskRunner and BindToCurrentThread

[Chromecast] Add BindToTaskRunner and BindToCurrentThread

We have a few locations where we want to bind a callback to run
on a specific task runner. We also use media::BindToCurrentLoop
in many places, even where there isn't necessarily a media
dependency. Now BindToCurrentThread can be used instead.

BUG= internal b/26273598
TEST= cast_base_unittests

Committed: https://crrev.com/5ff9107e04c398377052272a84c20da313a853fb
Cr-Commit-Position: refs/heads/master@{#367156}

[kmackay, 2015-12-29 23:09:55]

kmackay@chromium.org changed reviewers:
+ halliwell@chromium.org, maclellant@chromium.org

[maclellant, 2015-12-29 23:21:00]

lgtm % nit

https://codereview.chromium.org/1551843002/diff/20001/chromecast/base/bind_to...
File chromecast/base/bind_to_task_runner_unittest.cc (right):

https://codereview.chromium.org/1551843002/diff/20001/chromecast/base/bind_to...
chromecast/base/bind_to_task_runner_unittest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
Copyright (c) 2015

[kmackay, 2015-12-29 23:23:38]

https://codereview.chromium.org/1551843002/diff/20001/chromecast/base/bind_to...
File chromecast/base/bind_to_task_runner_unittest.cc (right):

https://codereview.chromium.org/1551843002/diff/20001/chromecast/base/bind_to...
chromecast/base/bind_to_task_runner_unittest.cc:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
On 2015/12/29 23:21:00, maclellant wrote:
> Copyright (c) 2015

Done.

[halliwell, 2015-12-30 15:03:28]

On 2015/12/29 23:23:38, kmackay wrote:
>
https://codereview.chromium.org/1551843002/diff/20001/chromecast/base/bind_to...
> File chromecast/base/bind_to_task_runner_unittest.cc (right):
> 
>
https://codereview.chromium.org/1551843002/diff/20001/chromecast/base/bind_to...
> chromecast/base/bind_to_task_runner_unittest.cc:1: // Copyright (c) 2012 The
> Chromium Authors. All rights reserved.
> On 2015/12/29 23:21:00, maclellant wrote:
> > Copyright (c) 2015
> 
> Done.

Please put [Chromecast] on front of commit description.

It seems a little unfortunate that we have to define something so generic.  Did
you consider reworking other (non-media) use cases to use other mechanisms (e.g.
PostTaskAndReply)?

[kmackay, 2015-12-30 15:56:26]

Description was changed from

==========
Add BindToTaskRunner and BindToCurrentThread

We have a few locations where we want to bind a callback to run
on a specific task runner. We also use media::BindToCurrentLoop
in many places, even where there isn't necessarily a media
dependency. Now BindToCurrentThread can be used instead.

BUG= internal b/26273598
TEST= cast_base_unittests
==========

to

==========
[Chromecast] Add BindToTaskRunner and BindToCurrentThread

We have a few locations where we want to bind a callback to run
on a specific task runner. We also use media::BindToCurrentLoop
in many places, even where there isn't necessarily a media
dependency. Now BindToCurrentThread can be used instead.

BUG= internal b/26273598
TEST= cast_base_unittests
==========

[kmackay, 2015-12-30 16:04:16]

> Please put [Chromecast] on front of commit description.
> 
> It seems a little unfortunate that we have to define something so generic. 
Did
> you consider reworking other (non-media) use cases to use other mechanisms
(e.g.
> PostTaskAndReply)?

The generality is what makes it useful. We want to be able to execute an
arbitrary callback on a specific task runner. I am already doing this in
multizone code in a specific way, and Tavis is doing the same thing in a CL he
is working on. Rather than copy-pasting the same code in several places and
modifying it for the specific instance, it makes more sense to define a generic
version. Also, this way we don't need to depend on media for BindToCurrentLoop
(eg in the multizone code).

[halliwell, 2015-12-30 16:13:00]

On 2015/12/30 16:04:16, kmackay wrote:
> > Please put [Chromecast] on front of commit description.
> > 
> > It seems a little unfortunate that we have to define something so generic. 
> Did
> > you consider reworking other (non-media) use cases to use other mechanisms
> (e.g.
> > PostTaskAndReply)?
> 
> The generality is what makes it useful. We want to be able to execute an
> arbitrary callback on a specific task runner. I am already doing this in
> multizone code in a specific way, and Tavis is doing the same thing in a CL he
> is working on. Rather than copy-pasting the same code in several places and
> modifying it for the specific instance, it makes more sense to define a
generic
> version. Also, this way we don't need to depend on media for BindToCurrentLoop
> (eg in the multizone code).

Right ... I'm not questioning why generality is useful, but why something so
general should be defined in chromecast/.  It doesn't seem like a
chromecast-specific concept at all.

So I was wondering if there's an existing construct in Chromium that we should
be using.  But I can't find one.

lgtm.

[kmackay, 2015-12-30 16:19:02]

> Right ... I'm not questioning why generality is useful, but why something so
> general should be defined in chromecast/.  It doesn't seem like a
> chromecast-specific concept at all.
> 
> So I was wondering if there's an existing construct in Chromium that we should
> be using.  But I can't find one.
> 
> lgtm.

Ah. I tried to upstream it to base/, but they were not enthusiastic.
https://codereview.chromium.org/1553593002/

[kmackay, 2015-12-30 16:19:18]

The CQ bit was checked by kmackay@chromium.org

[kmackay, 2015-12-30 16:19:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
maclellant@chromium.org
Link to the patchset: https://codereview.chromium.org/1551843002/#ps40001
(title: "Correct copyright notice")

[commit-bot: I haz the power, 2015-12-30 16:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551843002/40001

[commit-bot: I haz the power, 2015-12-30 16:48:28]

Description was changed from

==========
[Chromecast] Add BindToTaskRunner and BindToCurrentThread

We have a few locations where we want to bind a callback to run
on a specific task runner. We also use media::BindToCurrentLoop
in many places, even where there isn't necessarily a media
dependency. Now BindToCurrentThread can be used instead.

BUG= internal b/26273598
TEST= cast_base_unittests
==========

to

==========
[Chromecast] Add BindToTaskRunner and BindToCurrentThread

We have a few locations where we want to bind a callback to run
on a specific task runner. We also use media::BindToCurrentLoop
in many places, even where there isn't necessarily a media
dependency. Now BindToCurrentThread can be used instead.

BUG= internal b/26273598
TEST= cast_base_unittests
==========

[commit-bot: I haz the power, 2015-12-30 16:48:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-30 16:49:13]

Description was changed from

==========
[Chromecast] Add BindToTaskRunner and BindToCurrentThread

We have a few locations where we want to bind a callback to run
on a specific task runner. We also use media::BindToCurrentLoop
in many places, even where there isn't necessarily a media
dependency. Now BindToCurrentThread can be used instead.

BUG= internal b/26273598
TEST= cast_base_unittests
==========

to

==========
[Chromecast] Add BindToTaskRunner and BindToCurrentThread

We have a few locations where we want to bind a callback to run
on a specific task runner. We also use media::BindToCurrentLoop
in many places, even where there isn't necessarily a media
dependency. Now BindToCurrentThread can be used instead.

BUG= internal b/26273598
TEST= cast_base_unittests

Committed: https://crrev.com/5ff9107e04c398377052272a84c20da313a853fb
Cr-Commit-Position: refs/heads/master@{#367156}
==========

[commit-bot: I haz the power, 2015-12-30 16:49:14]

Patchset 3 (id:??) landed as
https://crrev.com/5ff9107e04c398377052272a84c20da313a853fb
Cr-Commit-Position: refs/heads/master@{#367156}

[halliwell, 2015-12-30 16:52:27]

On 2015/12/30 16:19:02, kmackay wrote:
> > Right ... I'm not questioning why generality is useful, but why something so
> > general should be defined in chromecast/.  It doesn't seem like a
> > chromecast-specific concept at all.
> > 
> > So I was wondering if there's an existing construct in Chromium that we
should
> > be using.  But I can't find one.
> > 
> > lgtm.
> 
> Ah. I tried to upstream it to base/, but they were not enthusiastic.
> https://codereview.chromium.org/1553593002/

Ha, ok ... thanks for trying! :)