Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: talk/media/webrtc/webrtcvoiceengine.cc

Issue 1551813002: Storing raw audio sink for default audio track. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding back "if (default_sink_)" when creating default stream. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/media/webrtc/webrtcvoiceengine.cc
diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc
index 9742564985bca6c0437865dafbe76803608e384a..19f0295cfa20e9cd8060644133ca5585f31df471 100644
--- a/talk/media/webrtc/webrtcvoiceengine.cc
+++ b/talk/media/webrtc/webrtcvoiceengine.cc
@@ -132,6 +132,16 @@ const int kMaxTelephoneEventCode = 255;
const int kMinTelephoneEventDuration = 100;
const int kMaxTelephoneEventDuration = 60000; // Actual limit is 2^16
+class ProxySink : public webrtc::AudioSinkInterface {
+ public:
+ ProxySink(AudioSinkInterface* sink) : sink_(sink) {}
the sun 2016/01/14 09:24:39 nit: explicit add RTC_DCHECK(sink_); in the ctor
Taylor Brandstetter 2016/01/14 15:48:47 Done.
+
+ void OnData(const Data& audio) override { sink_->OnData(audio); }
+
+ private:
+ webrtc::AudioSinkInterface* sink_;
+};
+
bool ValidateStreamParams(const StreamParams& sp) {
if (sp.ssrcs.empty()) {
LOG(LS_ERROR) << "No SSRCs in stream parameters: " << sp.ToString();
@@ -2186,6 +2196,11 @@ void WebRtcVoiceMediaChannel::OnPacketReceived(
}
default_recv_ssrc_ = ssrc;
SetOutputVolume(default_recv_ssrc_, default_recv_volume_);
+ if (default_sink_) {
+ rtc::scoped_ptr<webrtc::AudioSinkInterface> proxy_sink(
+ new ProxySink(default_sink_.get()));
+ SetRawAudioSink(default_recv_ssrc_, std::move(proxy_sink));
+ }
}
// Forward packet to Call. If the SSRC is unknown we'll return after this.
@@ -2414,7 +2429,17 @@ void WebRtcVoiceMediaChannel::SetRawAudioSink(
uint32_t ssrc,
rtc::scoped_ptr<webrtc::AudioSinkInterface> sink) {
RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
- LOG(LS_VERBOSE) << "WebRtcVoiceMediaChannel::SetRawAudioSink";
+ LOG(LS_VERBOSE) << "WebRtcVoiceMediaChannel::SetRawAudioSink: ssrc:" << ssrc
+ << " " << (sink ? "(ptr)" : "NULL");
+ if (ssrc == 0) {
+ if (default_recv_ssrc_ != -1) {
+ rtc::scoped_ptr<webrtc::AudioSinkInterface> proxy_sink(
+ sink ? new ProxySink(sink.get()) : nullptr);
+ SetRawAudioSink(default_recv_ssrc_, std::move(proxy_sink));
+ }
+ default_sink_ = std::move(sink);
+ return;
+ }
const auto it = recv_streams_.find(ssrc);
if (it == recv_streams_.end()) {
LOG(LS_WARNING) << "SetRawAudioSink: no recv stream" << ssrc;

Powered by Google App Engine
This is Rietveld 408576698