Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1551793002: Update TestExpectations for canvas-scale-strokePath-shadow.html (Closed)

Created:
4 years, 11 months ago by xidachen
Modified:
4 years, 11 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TestExpectations for canvas-scale-strokePath-shadow.html Currently, the expected.txt for this layout test is different comparing the virtual/gpu with platform/win-xp/virtual/gpu. Also, This test is marked as failure under platform/win-xp/virtual/gpu/, and the reason is that the actual output is the same as virtual/gpu. So this CL removes the expected.txt under platform/win-xp/virtual/gpu and the failure line under TestExpectations. BUG=568678 Committed: https://crrev.com/55b9604451329b9bb95aefa567236a5a056e5d47 Cr-Commit-Position: refs/heads/master@{#367087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/canvas-scale-strokePath-shadow-expected.txt View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xidachen
PTAL.
4 years, 11 months ago (2015-12-29 16:46:58 UTC) #2
Justin Novosad
LOL. lgtm
4 years, 11 months ago (2015-12-29 17:07:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551793002/1
4 years, 11 months ago (2015-12-29 17:52:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 18:40:01 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 18:41:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55b9604451329b9bb95aefa567236a5a056e5d47
Cr-Commit-Position: refs/heads/master@{#367087}

Powered by Google App Engine
This is Rietveld 408576698