third_party/harfbuzz-ng/src/hb-coretext.cc - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/src/hb-coretext.cc

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: thestig Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/harfbuzz-ng/src/hb-coretext.cc

diff --git a/third_party/harfbuzz-ng/src/hb-coretext.cc b/third_party/harfbuzz-ng/src/hb-coretext.cc

index 13ba5d94ef1d7c2eba1ae0a3c29ccf987e031a83..316d281eacf40337148e785f1605005d4b91f0a2 100644

--- a/third_party/harfbuzz-ng/src/hb-coretext.cc

+++ b/third_party/harfbuzz-ng/src/hb-coretext.cc

@@ -693,7 +693,6 @@ resize_and_retry:

scratch += old_scratch_used;

scratch_size -= old_scratch_used;

}

-retry:

{

string_ref = CFStringCreateWithCharactersNoCopy (NULL,

pchars, chars_len,

@@ -1129,10 +1128,6 @@ fail:

* AAT shaper

-HB_SHAPER_DATA_ENSURE_DECLARE(coretext_aat, face)

-HB_SHAPER_DATA_ENSURE_DECLARE(coretext_aat, font)

* shaper face data

« no previous file with comments | « third_party/harfbuzz-ng/README.chromium ('k') | third_party/mach_override/BUILD.gn » ('j') | no next file with comments »