chrome/browser/chromeos/extensions/accessibility_features_apitest.cc - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: thestig Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/chromeos/file_system_provider/provided_file_system_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

diff --git a/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc b/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

index 4b3a11f22274986c451da2a8f281793f6e0d89b6..30f0451cb152c339914c79d8589da1d502ae20e1 100644

--- a/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

+++ b/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

@@ -69,7 +69,7 @@ class AccessibilityFeaturesApiTest : public ExtensionApiTest,

bool ShouldModifyingFeatureSucceed() const { return GetParam(); }

// Returns preference path for accessibility features as defined by the API.

- const char* const GetPrefForFeature(const std::string& feature) {

+ const char* GetPrefForFeature(const std::string& feature) {

if (feature == "spokenFeedback")

return prefs::kAccessibilitySpokenFeedbackEnabled;

if (feature == "largeCursor")