Build third-party code with -Wall, build chromium_code with -Wextra on Linux

third_party/ocmock/BUILD.gn

Index: third_party/ocmock/BUILD.gn
diff --git a/third_party/ocmock/BUILD.gn b/third_party/ocmock/BUILD.gn
index de51636c9ef9615eacf849343d13a5b7941a928f..7d9f70247de63386a17a1ce0d570ea0bccab32ed 100644
--- a/third_party/ocmock/BUILD.gn
+++ b/third_party/ocmock/BUILD.gn
@@ -8,6 +8,11 @@ config("ocmock_config") {
   include_dirs = [ "//third_party/ocmock" ]
 }
 
+config("ocmock_warnings") {
+  # NSInvocation+OCMAdditions.m has some `- (void) foo; {...`
+  cflags = [ "-Wno-semicolon-before-method-body" ]

[Lei Zhang, 2015/12/31 00:07:37]

Should this have an "if (is_clang)", like third_party/mach_override/BUILD.gn?

[Nico, 2015/12/31 02:44:17]

Doesn't matter either way, this is only build on is_mac || is_ios (see line 5),
and these always use clang

[Lei Zhang, 2015/12/31 02:56:59]

Shouldn't mach_override have the same assertion and drop the if, since it's mac
only as well? Just asking for consistency.

[Nico, 2015/12/31 03:05:58]

I agree. I'll send a separate CL for that.

+}
+
 source_set("ocmock") {
   testonly = true
 
@@ -70,4 +75,5 @@ source_set("ocmock") {
     "//testing/gtest",
   ]
   public_configs = [ ":ocmock_config" ]
+  configs += [ ":ocmock_warnings" ]
 }