base/android/jni_generator/jni_generator.gyp - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/jni_generator.gyp

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, and no -Wextra for pnacl-clang in gn for now Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/android/jni_generator/jni_generator.gyp

diff --git a/base/android/jni_generator/jni_generator.gyp b/base/android/jni_generator/jni_generator.gyp

index 4a17f3e57c1eea69c09dc738223f0a201d7a2cd4..139de2d0db0b627f028ab63836e1ee81d8c7060f 100644

--- a/base/android/jni_generator/jni_generator.gyp

+++ b/base/android/jni_generator/jni_generator.gyp

@@ -60,6 +60,13 @@

'jni_sample_header',

'jni_sample_java',

+ 'variables': {

+ 'clang_warning_flags': [

+ # The jni generator generates unused static functions in a header

+ # file, which is a bad idea, but this is only a test target.

+ '-Wno-unused-function',

+ ],

+ },

'sources': [

'sample_for_tests.cc',

« no previous file with comments | « base/android/context_utils.cc ('k') | build/common.gypi » ('j') | build/common.gypi » ('J')