Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: components/history/core/browser/android/android_history_types.h

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: thestig Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_ANDROID_ANDROID_HISTORY_TYPES_H_ 5 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_ANDROID_ANDROID_HISTORY_TYPES_H_
6 #define COMPONENTS_HISTORY_CORE_BROWSER_ANDROID_ANDROID_HISTORY_TYPES_H_ 6 #define COMPONENTS_HISTORY_CORE_BROWSER_ANDROID_ANDROID_HISTORY_TYPES_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 set_value_explicitly(ID); 120 set_value_explicitly(ID);
121 id_ = id; 121 id_ = id;
122 } 122 }
123 AndroidURLID id() const { return id_; } 123 AndroidURLID id() const { return id_; }
124 124
125 // The id of the parent folder containing the bookmark, if any. 125 // The id of the parent folder containing the bookmark, if any.
126 void set_parent_id(int64_t parent_id) { 126 void set_parent_id(int64_t parent_id) {
127 set_value_explicitly(PARENT_ID); 127 set_value_explicitly(PARENT_ID);
128 parent_id_ = parent_id; 128 parent_id_ = parent_id;
129 } 129 }
130 const int64_t parent_id() const { return parent_id_; } 130 int64_t parent_id() const { return parent_id_; }
131 131
132 // The internal URLID 132 // The internal URLID
133 void set_url_id(URLID url_id) { 133 void set_url_id(URLID url_id) {
134 set_value_explicitly(URL_ID); 134 set_value_explicitly(URL_ID);
135 url_id_ = url_id; 135 url_id_ = url_id;
136 } 136 }
137 URLID url_id() const { return url_id_; } 137 URLID url_id() const { return url_id_; }
138 138
139 // Returns true if the given |id| has been set explicitly. 139 // Returns true if the given |id| has been set explicitly.
140 bool is_value_set_explicitly(ColumnID id) const { 140 bool is_value_set_explicitly(ColumnID id) const {
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 private: 278 private:
279 scoped_ptr<sql::Statement> statement_; 279 scoped_ptr<sql::Statement> statement_;
280 int favicon_index_; 280 int favicon_index_;
281 281
282 DISALLOW_COPY_AND_ASSIGN(AndroidStatement); 282 DISALLOW_COPY_AND_ASSIGN(AndroidStatement);
283 }; 283 };
284 284
285 } // namespace history 285 } // namespace history
286 286
287 #endif // COMPONENTS_HISTORY_CORE_BROWSER_ANDROID_ANDROID_HISTORY_TYPES_H_ 287 #endif // COMPONENTS_HISTORY_CORE_BROWSER_ANDROID_ANDROID_HISTORY_TYPES_H_
OLDNEW
« no previous file with comments | « components/crash/content/app/breakpad_linux.cc ('k') | components/nacl/renderer/plugin/plugin.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698