Build third-party code with -Wall, build chromium_code with -Wextra on Linux

chromeos/system/statistics_provider.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/system/statistics_provider.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 200 matching lines @@
 
   // Extracts known data from regional_data_;
   // Returns true on success;
   bool GetRegionalInformation(const std::string& name,
                               std::string* result) const;
 
   // Returns current region dictionary or NULL if not found.
   const base::DictionaryValue* GetRegionDictionary() const;
 
   // Returns extractor from regional_data_extractors_ or nullptr.
-  const RegionDataExtractor GetRegionalDataExtractor(
-      const std::string& name) const;
+  RegionDataExtractor GetRegionalDataExtractor(const std::string& name) const;
 
   bool load_statistics_started_;
   NameValuePairsParser::NameValueMap machine_info_;
   MachineFlags machine_flags_;
   base::CancellationFlag cancellation_flag_;
   // |on_statistics_loaded_| protects |machine_info_| and |machine_flags_|.
   base::WaitableEvent on_statistics_loaded_;
   bool oem_manifest_loaded_;
   std::string region_;
   scoped_ptr<base::Value> regional_data_;
@@ skipping 32 matching lines @@
   if (!regional_data_->GetAsDictionary(&full_dict))
     return nullptr;
 
   const base::DictionaryValue* region_dict = nullptr;
   if (!full_dict->GetDictionaryWithoutPathExpansion(region_, &region_dict))
     return nullptr;
 
   return region_dict;
 }
 
-const StatisticsProviderImpl::RegionDataExtractor
+StatisticsProviderImpl::RegionDataExtractor
 StatisticsProviderImpl::GetRegionalDataExtractor(
     const std::string& name) const {
   const auto it = regional_data_extractors_.find(name);
   if (it == regional_data_extractors_.end())
     return nullptr;
 
   return it->second;
 }
 
 bool StatisticsProviderImpl::GetRegionalInformation(const std::string& name,
@@ skipping 273 matching lines @@
   return StatisticsProviderImpl::GetInstance();
 }
 
 // static
 void StatisticsProvider::SetTestProvider(StatisticsProvider* test_provider) {
   g_test_statistics_provider = test_provider;
 }
 
 }  // namespace system
 }  // namespace chromeos