Add chrome://flags for update menu item

Add chrome://flags for update menu item

BUG=566085
Committed: https://crrev.com/ce51db3b092a98fda99625204eb8abf4d4de79db
Cr-Commit-Position: refs/heads/master@{#367155}

[Theresa, 2015-12-29 00:12:26]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2015-12-29 00:12:26]

ptal

https://codereview.chromium.org/1551743002/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/1551743002/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:1336: const char
kForceShowUpdateMenuItemSummary[] = "show_summary";
Thoughts on adding actually command line switches for these (e.g.
--force-show-udpate-menu-item-summary) instead of reusing
VarationsAssociatedData param names?

[gone, 2015-12-29 01:49:00]

Do you need this much granularity on the switches (i.e. all four of these flags
exposed)?

https://codereview.chromium.org/1551743002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/1551743002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2124:
"https://market.android.com/details?id=com.android.chrome")},
I think we should update to Play Store URLs in the codebase at this point:
https://play.google.com/store/apps/details?id=com.android.chrome

https://codereview.chromium.org/1551743002/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/1551743002/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:1336: const char
kForceShowUpdateMenuItemSummary[] = "show_summary";
On 2015/12/29 00:12:26, Theresa Wellington wrote:
> Thoughts on adding actually command line switches for these (e.g.
> --force-show-udpate-menu-item-summary) instead of reusing
> VarationsAssociatedData param names?

Eh I'd just reuse.  Any idea if there's precedent for that?

[gone, 2015-12-29 18:11:21]

lgtm

[Theresa, 2015-12-29 18:16:26]

https://chromiumcodereview.appspot.com/1551743002/diff/20001/chrome/browser/a...
File chrome/browser/about_flags.cc (right):

https://chromiumcodereview.appspot.com/1551743002/diff/20001/chrome/browser/a...
chrome/browser/about_flags.cc:2124:
"https://market.android.com/details?id=com.android.chrome")},
On 2015/12/29 01:49:00, dfalcantara wrote:
> I think we should update to Play Store URLs in the codebase at this point:
> https://play.google.com/store/apps/details?id=com.android.chrome

Done.

https://chromiumcodereview.appspot.com/1551743002/diff/20001/chrome/common/ch...
File chrome/common/chrome_switches.cc (right):

https://chromiumcodereview.appspot.com/1551743002/diff/20001/chrome/common/ch...
chrome/common/chrome_switches.cc:1336: const char
kForceShowUpdateMenuItemSummary[] = "show_summary";
On 2015/12/29 01:49:00, dfalcantara wrote:
> On 2015/12/29 00:12:26, Theresa Wellington wrote:
> > Thoughts on adding actually command line switches for these (e.g.
> > --force-show-udpate-menu-item-summary) instead of reusing
> > VarationsAssociatedData param names?
> 
> Eh I'd just reuse.  Any idea if there's precedent for that?

I don't see any other flags except enforce_strict using the _ instead of -
syntax, but I think it's okay to reuse too.

[Theresa, 2015-12-29 18:19:08]

twellington@chromium.org changed reviewers:
+ holte@chromium.org

[Theresa, 2015-12-29 18:19:08]

holte@ - ptal at histograms.xml (added some values to the LoginCustomFlags enum)

[Steven Holte, 2015-12-30 01:26:23]

lgtm

[Theresa, 2015-12-30 16:20:17]

The CQ bit was checked by twellington@chromium.org

[commit-bot: I haz the power, 2015-12-30 16:20:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551743002/40001

[commit-bot: I haz the power, 2015-12-30 16:24:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-30 16:25:49]

Description was changed from

==========
Add chrome://flags for update menu item

BUG=566085
==========

to

==========
Add chrome://flags for update menu item

BUG=566085

Committed: https://crrev.com/ce51db3b092a98fda99625204eb8abf4d4de79db
Cr-Commit-Position: refs/heads/master@{#367155}
==========

[commit-bot: I haz the power, 2015-12-30 16:25:50]

Patchset 3 (id:??) landed as
https://crrev.com/ce51db3b092a98fda99625204eb8abf4d4de79db
Cr-Commit-Position: refs/heads/master@{#367155}