Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1551683002: [Blimp Client] Land CL 1528243002 (Add a basic linux client for Blimp) (Closed)

Created:
4 years, 12 months ago by haibinlu
Modified:
4 years, 6 months ago
Reviewers:
Kevin M, sky
CC:
chromium-reviews, dtrainor+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blimp Client] Land CL 1528243002 (Add a basic linux client for Blimp) Exactly the same as issue 1528243002 at patchset 20001 (http://crrev.com/1528243002#ps20001) BUG=534894 Committed: https://crrev.com/1028db14ebc45c0634f425a261069ac6228922fb Cr-Commit-Position: refs/heads/master@{#367040}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Avoid building blimp_shell on chromeos #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -36 lines) Patch
M blimp/BUILD.gn View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M blimp/client/BUILD.gn View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M blimp/client/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/client/android/blimp_library_loader.cc View 2 chunks +3 lines, -28 lines 0 comments Download
M blimp/client/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java View 2 chunks +1 line, -3 lines 0 comments Download
A blimp/client/blimp_startup.h View 1 chunk +18 lines, -0 lines 0 comments Download
A blimp/client/blimp_startup.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_compositor.h View 2 chunks +5 lines, -5 lines 0 comments Download
A blimp/client/linux/blimp_display_manager.h View 1 chunk +66 lines, -0 lines 0 comments Download
A blimp/client/linux/blimp_display_manager.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A blimp/client/linux/blimp_main.cc View 1 2 3 1 chunk +40 lines, -0 lines 0 comments Download
A blimp/client/session/blimp_client_session_linux.h View 1 chunk +36 lines, -0 lines 0 comments Download
A blimp/client/session/blimp_client_session_linux.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
Kevin M
holiday rubberstamp lgtm Someone from the client team can address the outstanding comments in a ...
4 years, 12 months ago (2015-12-28 19:32:04 UTC) #3
haibinlu
sky@, could I get your owners approval of the DEPS file?
4 years, 12 months ago (2015-12-28 19:34:55 UTC) #5
sky
DEPS LGTM
4 years, 12 months ago (2015-12-29 00:25:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551683002/1
4 years, 12 months ago (2015-12-29 00:36:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/124249)
4 years, 12 months ago (2015-12-29 00:42:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551683002/20001
4 years, 12 months ago (2015-12-29 01:00:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/124256)
4 years, 12 months ago (2015-12-29 01:06:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551683002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551683002/40001
4 years, 12 months ago (2015-12-29 01:25:51 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/124261)
4 years, 12 months ago (2015-12-29 01:33:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551683002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551683002/60001
4 years, 12 months ago (2015-12-29 01:41:48 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 12 months ago (2015-12-29 02:16:34 UTC) #25
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1028db14ebc45c0634f425a261069ac6228922fb Cr-Commit-Position: refs/heads/master@{#367040}
4 years, 12 months ago (2015-12-29 02:18:31 UTC) #27
Wez
4 years, 11 months ago (2016-01-05 19:15:57 UTC) #28
Re-opening for the comments from the original review
(https://codereview.chromium.org/1528243002/) to be addressed.

Powered by Google App Engine
This is Rietveld 408576698