Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1551673002: remove use of malloc.h (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove use of malloc.h It's non-portable, commented out, and those asserts are not important. Let's just blow it away. BUG=skia:4736 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1551673002 Committed: https://skia.googlesource.com/skia/+/29dd813b13719b9d7082a017ce79590f1706dccd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M src/core/SkVarAlloc.cpp View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551673002/1
4 years, 11 months ago (2015-12-28 19:17:40 UTC) #3
mtklein_C
4 years, 11 months ago (2015-12-28 19:25:16 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-28 19:37:09 UTC) #7
reed1
lgtm
4 years, 11 months ago (2016-01-04 16:08:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551673002/1
4 years, 11 months ago (2016-01-05 02:35:59 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 02:50:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/29dd813b13719b9d7082a017ce79590f1706dccd

Powered by Google App Engine
This is Rietveld 408576698