blimp/net/common.cc - Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/common.cc

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002

Patch Set: Haibin feedback Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/net/common.cc

diff --git a/blimp/net/common.cc b/blimp/net/common.cc

index 1663b300534f03ff610710b6d2630a5f7c04c427..7f66fce021280d40efde02117e82c4a23ba822c0 100644

--- a/blimp/net/common.cc

+++ b/blimp/net/common.cc

@@ -4,9 +4,21 @@

#include "blimp/net/common.h"

+#include <iostream>

+#include "blimp/common/proto/blimp_message.pb.h"

+#include "net/base/ip_address_number.h"

namespace blimp {

const size_t kMaxPacketPayloadSizeBytes = 1 << 16; // 64KB

const size_t kPacketHeaderSizeBytes = 4;

+std::ostream& operator<<(std::ostream& out, const BlimpMessage& message) {

+ // TODO(kmarshall): Log type-specific contextual detail.

haibinlu 2016/01/04 21:17:12 how do you get contextual detail?

+ out << "<BlimpMessage type=" << message.type()

+ << ", size=" << message.ByteSize() << ">";

+ return out;

} // namespace blimp

« no previous file with comments | « blimp/net/common.h ('k') | blimp/net/engine_authentication_handler.cc » ('j') | no next file with comments »