blimp/net/test_common.h - Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/test_common.h

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002

Patch Set: Addressed haibin's feedback, made an ObserverList for ConnectionErrorObserver Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/net/test_common.h

diff --git a/blimp/net/test_common.h b/blimp/net/test_common.h

index bc95e784a8dd3bdcb646d9e4c62a8f32adae2ce9..5586b4afec27028c2863ffde2b72776265985999 100644

--- a/blimp/net/test_common.h

+++ b/blimp/net/test_common.h

@@ -180,7 +180,13 @@ class MockBlimpConnection : public BlimpConnection {

MOCK_METHOD1(SetIncomingMessageProcessor,

void(BlimpMessageProcessor* processor));

- MOCK_METHOD0(GetOutgoingMessageProcessor, BlimpMessageProcessor*());

+ MOCK_METHOD1(AddConnectionErrorObserver, void(ConnectionErrorObserver*));

+ MOCK_METHOD0(ClearConnectionErrorObservers, void(void));

+ MOCK_METHOD1(RemoveConnectionErrorObserver, void(ConnectionErrorObserver*));

+ MOCK_METHOD0(GetOutgoingMessageProcessor, BlimpMessageProcessor*(void));

};

class MockConnectionErrorObserver : public ConnectionErrorObserver {

« blimp/net/common.cc ('K') | « blimp/net/stream_packet_reader.cc ('k') | no next file » | no next file with comments »