blimp/net/blimp_connection_unittest.cc - Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/blimp_connection_unittest.cc

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002

Patch Set: Addressed haibin's feedback, made an ObserverList for ConnectionErrorObserver Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/net/blimp_connection_unittest.cc

diff --git a/blimp/net/blimp_connection_unittest.cc b/blimp/net/blimp_connection_unittest.cc

index 8816b14fdd37492e9fefb6e4298c3c58a56a9f2f..8647673a68deed2bbc8235c45e3ce58af7aebaed 100644

--- a/blimp/net/blimp_connection_unittest.cc

+++ b/blimp/net/blimp_connection_unittest.cc

@@ -35,7 +35,7 @@ class BlimpConnectionTest : public testing::Test {

writer_ = writer.get();

connection_.reset(new BlimpConnection(make_scoped_ptr(new MockPacketReader),

std::move(writer)));

- connection_->SetConnectionErrorObserver(&error_observer_);

+ connection_->AddConnectionErrorObserver(&error_observer_);

haibinlu 2016/01/04 19:45:45 add 2 error observers.

Kevin M 2016/01/04 20:42:13 Added 3 and removed 1 to test the logic for adding

}

~BlimpConnectionTest() override {}

« blimp/net/blimp_connection.cc ('K') | « blimp/net/blimp_connection.cc ('k') | blimp/net/blimp_message_demultiplexer.cc » ('j') | blimp/net/blimp_message_pump.cc » ('J')