blimp/BUILD.gn - Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/BUILD.gn

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002

Patch Set: Addressed haibin's feedback, made an ObserverList for ConnectionErrorObserver Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/BUILD.gn

diff --git a/blimp/BUILD.gn b/blimp/BUILD.gn

index 67120953590cfd3676d95da77666e103ed145f64..03ea56b542986306cbd61d783eea42ce8bb44ea0 100644

--- a/blimp/BUILD.gn

+++ b/blimp/BUILD.gn

@@ -23,6 +23,7 @@ group("blimp") {

if (is_linux) {

deps += [

+ "//blimp/client:blimp_shell",

haibinlu 2016/01/04 19:45:45 remove this?

Kevin M 2016/01/04 20:42:12 It's important to keep this in, so that the Linux

Kevin M 2016/01/04 21:09:10 Talked about this offline. Didn't see it declared

"//blimp/engine:blimp_engine",

"//blimp/engine:blimp_engine_bundle",

]

« no previous file with comments | « no previous file | blimp/client/BUILD.gn » ('j') | blimp/client/session/blimp_client_session.h » ('J')