Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3494)

Unified Diff: blimp/net/browser_connection_handler_unittest.cc

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002
Patch Set: Fixed misplaced EXPORT directive Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/net/browser_connection_handler.cc ('k') | blimp/net/client_connection_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/browser_connection_handler_unittest.cc
diff --git a/blimp/net/browser_connection_handler_unittest.cc b/blimp/net/browser_connection_handler_unittest.cc
index c838ba6e868721af76093200a5050bbe099964a8..2a9f739224ad03d3408ff2285fa68aeb794484ae 100644
--- a/blimp/net/browser_connection_handler_unittest.cc
+++ b/blimp/net/browser_connection_handler_unittest.cc
@@ -77,7 +77,7 @@ class FakeBlimpConnection : public BlimpConnection,
ConnectionErrorObserver* error_observer() { return error_observer_; }
// BlimpConnection implementation.
- void SetConnectionErrorObserver(ConnectionErrorObserver* observer) override {
+ void AddConnectionErrorObserver(ConnectionErrorObserver* observer) override {
error_observer_ = observer;
}
@@ -209,7 +209,10 @@ TEST_F(BrowserConnectionHandlerTest, ReconnectionAfterError) {
MockableProcessMessage(EqualsMessageIgnoringId(*client_input_message), _))
.RetiresOnSaturation();
+ // Simulate a connection failure.
client_connection_->error_observer()->OnConnectionError(net::ERR_FAILED);
+ engine_connection_->error_observer()->OnConnectionError(net::ERR_FAILED);
+
// Message will be queued to be transmitted when the connection is
// re-established.
client_input_feature_->outgoing_message_processor()->ProcessMessage(
« no previous file with comments | « blimp/net/browser_connection_handler.cc ('k') | blimp/net/client_connection_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698