Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: blimp/net/blimp_message_pump.cc

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002
Patch Set: Fixed misplaced EXPORT directive Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/net/blimp_message_pump.h ('k') | blimp/net/browser_connection_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/blimp_message_pump.cc
diff --git a/blimp/net/blimp_message_pump.cc b/blimp/net/blimp_message_pump.cc
index adeed65a6176824edb64f4a4d05160989ce5e090..ae264e1fd8948d68b44bfdab021b7ef6f8e27f46 100644
--- a/blimp/net/blimp_message_pump.cc
+++ b/blimp/net/blimp_message_pump.cc
@@ -30,6 +30,7 @@ BlimpMessagePump::BlimpMessagePump(PacketReader* reader)
BlimpMessagePump::~BlimpMessagePump() {}
void BlimpMessagePump::SetMessageProcessor(BlimpMessageProcessor* processor) {
+ DVLOG(1) << "SetMessageProcessor, processor=" << processor;
if (processor && !processor_) {
processor_ = processor;
ReadNextPacket();
@@ -43,6 +44,7 @@ void BlimpMessagePump::SetMessageProcessor(BlimpMessageProcessor* processor) {
}
void BlimpMessagePump::ReadNextPacket() {
+ DVLOG(2) << "ReadNextPacket";
DCHECK(processor_);
DCHECK(!read_inflight_);
read_inflight_ = true;
@@ -51,6 +53,7 @@ void BlimpMessagePump::ReadNextPacket() {
}
void BlimpMessagePump::OnReadPacketComplete(int result) {
+ DVLOG(2) << "OnReadPacketComplete, result=" << result;
DCHECK(read_inflight_);
read_inflight_ = false;
if (result == net::OK) {
@@ -69,8 +72,13 @@ void BlimpMessagePump::OnReadPacketComplete(int result) {
}
void BlimpMessagePump::OnProcessMessageComplete(int result) {
- // No error is expected from the message receiver.
- DCHECK_EQ(net::OK, result);
+ DVLOG(2) << "OnProcessMessageComplete, result=" << result;
+
+ if (result != net::OK) {
+ error_observer_->OnConnectionError(result);
+ return;
+ }
+
if (processor_)
ReadNextPacket();
}
« no previous file with comments | « blimp/net/blimp_message_pump.h ('k') | blimp/net/browser_connection_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698