Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2281)

Unified Diff: blimp/net/blimp_message_demultiplexer.cc

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002
Patch Set: Fixed misplaced EXPORT directive Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/net/blimp_connection_unittest.cc ('k') | blimp/net/blimp_message_demultiplexer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/blimp_message_demultiplexer.cc
diff --git a/blimp/net/blimp_message_demultiplexer.cc b/blimp/net/blimp_message_demultiplexer.cc
index 6a1fa64b66a9052b3f8909a8e8d56dc4e782a525..1444c9fdade860227b509fe6c218bfeaa9c9a800 100644
--- a/blimp/net/blimp_message_demultiplexer.cc
+++ b/blimp/net/blimp_message_demultiplexer.cc
@@ -7,16 +7,10 @@
#include <string>
#include "base/strings/stringprintf.h"
+#include "blimp/net/common.h"
#include "net/base/net_errors.h"
namespace blimp {
-namespace {
-
-std::string BlimpMessageToDebugString(const BlimpMessage& message) {
- return base::StringPrintf("<message type=%d>", message.type());
-}
-
-} // namespace
BlimpMessageDemultiplexer::BlimpMessageDemultiplexer() {}
@@ -37,11 +31,11 @@ void BlimpMessageDemultiplexer::ProcessMessage(
const net::CompletionCallback& callback) {
auto receiver_iter = feature_receiver_map_.find(message->type());
if (receiver_iter == feature_receiver_map_.end()) {
- DLOG(FATAL) << "No registered receiver for "
- << BlimpMessageToDebugString(*message) << ".";
+ DLOG(ERROR) << "No registered receiver for " << *message << ".";
if (!callback.is_null()) {
callback.Run(net::ERR_NOT_IMPLEMENTED);
}
+ return;
}
receiver_iter->second->ProcessMessage(std::move(message), callback);
« no previous file with comments | « blimp/net/blimp_connection_unittest.cc ('k') | blimp/net/blimp_message_demultiplexer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698