Implementation and fixes for Blimp client/engine E2E communication.

blimp/client/linux/blimp_main.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <X11/Xlib.h>
+
 #include <string>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
+#include "base/threading/thread.h"
 #include "blimp/client/blimp_startup.h"
 #include "blimp/client/session/blimp_client_session_linux.h"
 #include "blimp/client/session/navigation_feature.h"
 
-#include <X11/Xlib.h>
-
 namespace {
 const char kDefaultUrl[] = "https://www.google.com";
 const int kDummyTabId = 0;
 }
 
 int main(int argc, const char**argv) {
   base::AtExitManager at_exit;
 
   base::CommandLine::Init(argc, argv);
 
   XInitThreads();
 
   blimp::InitializeLogging();
   blimp::InitializeMainMessageLoop();
 
   blimp::BlimpClientSessionLinux session;
 
+  // Create the IO thread and initiate a connection on it.
+  base::Thread::Options options;
+  options.message_loop_type = base::MessageLoop::TYPE_IO;
+  base::Thread io_thread("BlimpIOThread");
+  io_thread.StartWithOptions(options);
+  io_thread.message_loop()->PostTask(

[haibinlu, 2015/12/29 00:51:45]

it is a little strange to run BlimpClientSession::Connect in the IO thread,
since BlimpClientSession is a UI thread object. BlimpNetworkComponent is a good
place for methods to run on IO thread.

[Kevin M, 2015/12/30 23:08:48]

Done. Moved IO thread setup into ClientSession, calling Connect from
NetworkComponents.

+      FROM_HERE, base::Bind(&blimp::BlimpClientSession::Connect,
+                            base::Unretained(&session)));
+
   // If there is a non-switch argument to the command line, load that url.
   base::CommandLine::StringVector args =
       base::CommandLine::ForCurrentProcess()->GetArgs();
   std::string url = args.size() > 0 ? args[0] : kDefaultUrl;
 
   session.GetNavigationFeature()->NavigateToUrlText(kDummyTabId, url);
 
   base::RunLoop().Run();
 }