Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1551573002: Clear box from percentage descendants when it is split off from the ancestor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index fb82a7c0afc2369dcb56c705915c16ed387d0d39..3090020c1eb529694d5a26df914b7eb4e0f1ba1c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -4694,6 +4694,11 @@ LayoutObject* LayoutBox::splitAnonymousBoxesAroundChild(LayoutObject* beforeChil
markBoxForRelayoutAfterSplit(boxToSplit);
markBoxForRelayoutAfterSplit(postBox);
+ // Splitting the box means the left side of the container chain will lose any percent height descendants
+ // below |postBox| in the right hand side.
+ if (LayoutBlock::hasPercentHeightContainerMap())
+ LayoutBlock::clearPercentHeightDescendantsFrom(postBox);
mstensho (USE GERRIT) 2016/01/25 09:17:07 This will process the entire postBox subtree, whic
rhogan 2016/01/25 19:14:55 :$ Updated this and the test. Thanks.
+
beforeChild = postBox;
} else {
beforeChild = boxToSplit;

Powered by Google App Engine
This is Rietveld 408576698