Clear box from percentage descendants when it is split off from the ancestor

third_party/WebKit/Source/core/layout/LayoutBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 4640 matching lines @@
             // We need to invalidate the |parentBox| before inserting the new node
             // so that the table paint invalidation logic knows the structure is dirty.
             // See for example LayoutTableCell:clippedOverflowRectForPaintInvalidation.
             markBoxForRelayoutAfterSplit(parentBox);
             parentBox->virtualChildren()->insertChildNode(parentBox, postBox, boxToSplit->nextSibling());
             boxToSplit->moveChildrenTo(postBox, beforeChild, 0, true);
 
             markBoxForRelayoutAfterSplit(boxToSplit);
             markBoxForRelayoutAfterSplit(postBox);
 
+            // Splitting the box means the left side of the container chain will lose any percent height descendants
+            // below |postBox| in the right hand side.
+            if (LayoutBlock::hasPercentHeightContainerMap())

[mstensho (USE GERRIT), 2016/01/18 20:06:24]

Can this be moved to a separate CL? This change isn't mentioned in the
description. If everything really has to be done in one and the same CL (not
that it's a lot, but it's two things, nonetheless), better update the
description.

[mstensho (USE GERRIT), 2016/01/21 19:12:32]

Well? :)

+                LayoutBlock::clearPercentHeightDescendantsFrom(postBox);
+
             beforeChild = postBox;
         } else {
-            beforeChild = boxToSplit;
+            // If a lone anonymous block is now unnecessary. Collapse it away and skip to its parent.

[mstensho (USE GERRIT), 2016/01/18 20:06:24]

"If" without "then". :-P

Did you mean to write this in one sentence? "... unnecessary, collapse ..."

+            if (!boxToSplit->isLayoutBlock() || !toLayoutBlock(boxToSplit)->collapseLoneAnonymousBlock(toLayoutBlock(boxToSplit)))

[mstensho (USE GERRIT), 2016/01/18 20:06:24]

I hope collapseLoneAnonymousBlock() can be static. This looks silly. :)

+                beforeChild = boxToSplit;
         }

[mstensho (USE GERRIT), 2016/01/18 20:06:24]

What if collapseLoneAnonymousBlock() did something here and returned true? Then
|beforeChild| isn't updated. Aren't you going to get stuck in this loop then?

     }
 
     if (didSplitParentAnonymousBoxes)
         markBoxForRelayoutAfterSplit(this);
 
     ASSERT(beforeChild->parent() == this);
     return beforeChild;
 }
 
 LayoutUnit LayoutBox::offsetFromLogicalTopOfFirstPage() const
@@ skipping 193 matching lines @@
 }
 
 void LayoutBox::clearPreviousPaintInvalidationRects()
 {
     LayoutBoxModelObject::clearPreviousPaintInvalidationRects();
     if (PaintLayerScrollableArea* scrollableArea = this->scrollableArea())
         scrollableArea->clearPreviousPaintInvalidationRects();
 }
 
 } // namespace blink