Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1551543002: Fix wrong comments about two search engine related variables (Closed)

Created:
4 years, 12 months ago by Ian Wen
Modified:
4 years, 12 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong comments about two search engine related variables Search provider specified by preferences and by extensions have wrong comments. This CL fixes it. BUG=NONE Committed: https://crrev.com/d74193f29c50bc4b311daf0ae6c1c76172f2af68 Cr-Commit-Position: refs/heads/master@{#366969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/search_engines/default_search_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
PTAL :)
4 years, 12 months ago (2015-12-28 05:42:06 UTC) #2
Peter Kasting
LGTM
4 years, 12 months ago (2015-12-28 12:59:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551543002/1
4 years, 12 months ago (2015-12-28 13:02:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 13:38:51 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 13:40:00 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d74193f29c50bc4b311daf0ae6c1c76172f2af68
Cr-Commit-Position: refs/heads/master@{#366969}

Powered by Google App Engine
This is Rietveld 408576698