Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Side by Side Diff: components/ssl_errors/error_info.cc

Issue 1551513002: Add a missing switch-case break in ssl_errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ssl_errors/error_info.h" 5 #include "components/ssl_errors/error_info.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/i18n/message_formatter.h" 9 #include "base/i18n/message_formatter.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_WEAK_KEY_DETAILS, 129 details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_WEAK_KEY_DETAILS,
130 UTF8ToUTF16(request_url.host())); 130 UTF8ToUTF16(request_url.host()));
131 short_description = 131 short_description =
132 l10n_util::GetStringUTF16(IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION); 132 l10n_util::GetStringUTF16(IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION);
133 break; 133 break;
134 case CERT_WEAK_KEY_DH: 134 case CERT_WEAK_KEY_DH:
135 details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_WEAK_KEY_DETAILS, 135 details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_WEAK_KEY_DETAILS,
136 UTF8ToUTF16(request_url.host())); 136 UTF8ToUTF16(request_url.host()));
137 short_description = 137 short_description =
138 l10n_util::GetStringUTF16(IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION); 138 l10n_util::GetStringUTF16(IDS_CERT_ERROR_WEAK_KEY_DESCRIPTION);
139 break;
139 case CERT_NAME_CONSTRAINT_VIOLATION: 140 case CERT_NAME_CONSTRAINT_VIOLATION:
140 details = l10n_util::GetStringFUTF16( 141 details = l10n_util::GetStringFUTF16(
141 IDS_CERT_ERROR_NAME_CONSTRAINT_VIOLATION_DETAILS, 142 IDS_CERT_ERROR_NAME_CONSTRAINT_VIOLATION_DETAILS,
142 UTF8ToUTF16(request_url.host())); 143 UTF8ToUTF16(request_url.host()));
143 short_description = l10n_util::GetStringUTF16( 144 short_description = l10n_util::GetStringUTF16(
144 IDS_CERT_ERROR_NAME_CONSTRAINT_VIOLATION_DESCRIPTION); 145 IDS_CERT_ERROR_NAME_CONSTRAINT_VIOLATION_DESCRIPTION);
145 break; 146 break;
146 case CERT_VALIDITY_TOO_LONG: 147 case CERT_VALIDITY_TOO_LONG:
147 details = 148 details =
148 l10n_util::GetStringFUTF16(IDS_CERT_ERROR_VALIDITY_TOO_LONG_DETAILS, 149 l10n_util::GetStringFUTF16(IDS_CERT_ERROR_VALIDITY_TOO_LONG_DETAILS,
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 250
250 for (size_t i = 0; i < arraysize(kErrorFlags); ++i) { 251 for (size_t i = 0; i < arraysize(kErrorFlags); ++i) {
251 if ((cert_status & kErrorFlags[i]) && errors) { 252 if ((cert_status & kErrorFlags[i]) && errors) {
252 errors->push_back( 253 errors->push_back(
253 ErrorInfo::CreateError(kErrorTypes[i], cert.get(), url)); 254 ErrorInfo::CreateError(kErrorTypes[i], cert.get(), url));
254 } 255 }
255 } 256 }
256 } 257 }
257 258
258 } // namespace ssl_errors 259 } // namespace ssl_errors
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698