chrome/test/chromedriver/session.cc - Issue 1551503002: Convert Pass()→std::move() in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/session.cc

diff --git a/chrome/test/chromedriver/session.cc b/chrome/test/chromedriver/session.cc

index df7d67424a7699f819d88fe1f27a221188eb8439..b81663db830f0b950d3d93dd98344c3142efa79d 100644

--- a/chrome/test/chromedriver/session.cc

+++ b/chrome/test/chromedriver/session.cc

@@ -5,6 +5,7 @@

#include "chrome/test/chromedriver/session.h"

#include <list>

+#include <utility>

#include "base/lazy_instance.h"

#include "base/threading/thread_local.h"

@@ -46,7 +47,7 @@ Session::Session(const std::string& id, scoped_ptr<Chrome> chrome)

quit(false),

detach(false),

force_devtools_screenshot(false),

- chrome(chrome.Pass()),

+ chrome(std::move(chrome)),

sticky_modifiers(0),

mouse_position(0, 0),

page_load_timeout(kDefaultPageLoadTimeout),