chrome/test/chromedriver/logging.cc - Issue 1551503002: Convert Pass()→std::move() in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/logging.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/logging.cc

diff --git a/chrome/test/chromedriver/logging.cc b/chrome/test/chromedriver/logging.cc

index 935ef73648a110d8fd1eab76feb48004224295ce..6cdc71c924cc7a0207d4e9cc95ed09ea6c2e0678 100644

--- a/chrome/test/chromedriver/logging.cc

+++ b/chrome/test/chromedriver/logging.cc

@@ -150,7 +150,7 @@ WebDriverLog::~WebDriverLog() {

scoped_ptr<base::ListValue> WebDriverLog::GetAndClearEntries() {

scoped_ptr<base::ListValue> ret(entries_.release());

entries_.reset(new base::ListValue());

- return ret.Pass();

+ return ret;

}

std::string WebDriverLog::GetFirstErrorMessage() const {