chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc - Issue 1551503002: Convert Pass()→std::move() in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sessions/tab_restore_service_factory.cc ('K') | « chrome/common/extensions/chrome_extensions_client.cc ('k') | chrome/common/extensions/manifest_handlers/automation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc

diff --git a/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc b/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc

index 95eb719b0c1d040533400a16251a0a4cefd6793e..ff29ab3714d0729b0a2c8d0c13e6c6e5198a2f39 100644

--- a/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc

+++ b/chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc

@@ -246,7 +246,7 @@ TEST_F(ChromeChannelFeatureFilterTest, ComplexFeatureAvailability) {

.Set("extension_types", std::move(ListBuilder().Append("extension")))

.Build());

simple_feature->Parse(rule.get());

- features->push_back(simple_feature.Pass());

+ features->push_back(std::move(simple_feature));

// Rule: "legacy_packaged_app", channel stable.

simple_feature.reset(CreateFeature<SimpleFeature>());

@@ -256,9 +256,9 @@ TEST_F(ChromeChannelFeatureFilterTest, ComplexFeatureAvailability) {

std::move(ListBuilder().Append("legacy_packaged_app")))

.Build();

simple_feature->Parse(rule.get());

- features->push_back(simple_feature.Pass());

+ features->push_back(std::move(simple_feature));

- scoped_ptr<ComplexFeature> feature(new ComplexFeature(features.Pass()));

+ scoped_ptr<ComplexFeature> feature(new ComplexFeature(std::move(features)));

// Test match 1st rule.

{