chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc - Issue 1551503002: Convert Pass()→std::move() in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sessions/tab_restore_service_factory.cc ('K') | « chrome/common/extensions/api/extension_action/action_info.cc ('k') | chrome/common/extensions/chrome_extensions_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

diff --git a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

index 69972a396f4c69a5b10b439f0dd64eb78a2722c4..7a0a64c4effbb346666b386396d7ef8adad234b8 100644

--- a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <utility>

#include "chrome/common/extensions/api/extension_action/action_info.h"

#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

#include "extensions/common/constants.h"

@@ -122,7 +124,7 @@ TEST_F(BrowserActionManifestTest,

base::string16 error = ErrorUtils::FormatErrorMessageUTF16(

errors::kInvalidIconPath, "19");

LoadAndExpectError(

- ManifestData(manifest_value.Pass(), "Invalid default icon"),

+ ManifestData(std::move(manifest_value), "Invalid default icon"),

errors::kInvalidIconPath);

}