Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_libsecret.cc
diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc
index 5ad849b53b5e76b278fe7c82c53f8c6c52714501..525cc863b9697f0bf7d22a3b1a4f57b030d25c96 100644
--- a/chrome/browser/password_manager/native_backend_libsecret.cc
+++ b/chrome/browser/password_manager/native_backend_libsecret.cc
@@ -8,6 +8,7 @@
#include <stddef.h>
#include <stdint.h>
#include <list>
+#include <utility>
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
@@ -203,7 +204,7 @@ scoped_ptr<PasswordForm> FormOutOfAttributes(GHashTable* attrs) {
: password_manager::metrics_util::GNOME_FAILURE;
LogFormDataDeserializationStatus(status);
}
- return form.Pass();
+ return form;
}
class LibsecretAttributesBuilder {
@@ -625,7 +626,7 @@ ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::ConvertFormList(
} else {
LOG(WARNING) << "Unable to access password from list element!";
}
- forms.push_back(form.Pass());
+ forms.push_back(std::move(form));
} else {
VLOG(1) << "Could not initialize PasswordForm from attributes!";
}
@@ -643,5 +644,5 @@ ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::ConvertFormList(
password_manager::PSL_DOMAIN_MATCH_COUNT);
}
g_list_free(found);
- return forms.Pass();
+ return forms;
}

Powered by Google App Engine
This is Rietveld 408576698