Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index d25440f41e0ce185dfa38aa220fc7619a2252c9f..51b60b8226b9eeabc8d32d7fdda137731fe70e72 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
#include <string>
+#include <utility>
#include "base/bind.h"
#include "base/bind_helpers.h"
@@ -226,9 +227,10 @@ bool ChromePasswordManagerClient::PromptUserToSaveOrUpdatePassword(
PasswordsClientUIDelegateFromWebContents(web_contents());
if (update_password && IsUpdatePasswordUIEnabled()) {
manage_passwords_ui_controller->OnUpdatePasswordSubmitted(
- form_to_save.Pass());
+ std::move(form_to_save));
} else {
- manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass());
+ manage_passwords_ui_controller->OnPasswordSubmitted(
+ std::move(form_to_save));
}
} else {
#if defined(OS_MACOSX) || BUILDFLAG(ANDROID_JAVA_UI)
@@ -262,8 +264,8 @@ bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
return true;
#else
return PasswordsClientUIDelegateFromWebContents(web_contents())
- ->OnChooseCredentials(local_forms.Pass(), federated_forms.Pass(), origin,
- callback);
+ ->OnChooseCredentials(std::move(local_forms), std::move(federated_forms),
+ origin, callback);
#endif
}
@@ -280,7 +282,7 @@ void ChromePasswordManagerClient::NotifyUserAutoSignin(
ShowAutoSigninPrompt(web_contents(), local_forms[0]->username_value);
#else
PasswordsClientUIDelegateFromWebContents(web_contents())
- ->OnAutoSignin(local_forms.Pass());
+ ->OnAutoSignin(std::move(local_forms));
#endif
}
@@ -294,7 +296,7 @@ void ChromePasswordManagerClient::AutomaticPasswordSave(
PasswordsClientUIDelegate* manage_passwords_ui_controller =
PasswordsClientUIDelegateFromWebContents(web_contents());
manage_passwords_ui_controller->OnAutomaticPasswordSave(
- saved_form.Pass());
+ std::move(saved_form));
}
#endif
}

Powered by Google App Engine
This is Rietveld 408576698