chrome/browser/engagement/site_engagement_helper.cc - Issue 1551503002: Convert Pass()→std::move() in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_helper.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_helper.cc

diff --git a/chrome/browser/engagement/site_engagement_helper.cc b/chrome/browser/engagement/site_engagement_helper.cc

index ada901b5351263117bf0e2753e478230b0a264c9..ab85b815c35c0c11fb9fa219e7de1349a24c3bec 100644

--- a/chrome/browser/engagement/site_engagement_helper.cc

+++ b/chrome/browser/engagement/site_engagement_helper.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/engagement/site_engagement_helper.h"

+#include <utility>

#include "base/time/time.h"

#include "base/trace_event/trace_event.h"

#include "chrome/browser/engagement/site_engagement_service.h"

@@ -51,7 +53,7 @@ bool SiteEngagementHelper::PeriodicTracker::IsTimerRunning() {

void SiteEngagementHelper::PeriodicTracker::SetPauseTimerForTesting(

scoped_ptr<base::Timer> timer) {

- pause_timer_ = timer.Pass();

+ pause_timer_ = std::move(timer);

}

void SiteEngagementHelper::PeriodicTracker::StartTimer(