Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: chrome/browser/component_updater/cld_component_installer_unittest.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/cld_component_installer_unittest.cc
diff --git a/chrome/browser/component_updater/cld_component_installer_unittest.cc b/chrome/browser/component_updater/cld_component_installer_unittest.cc
index f83565be3c7584040d4326c6e22a1b23dcb0096d..97ceb443741306cbba1e97dffbe99fd8e0f9fdb5 100644
--- a/chrome/browser/component_updater/cld_component_installer_unittest.cc
+++ b/chrome/browser/component_updater/cld_component_installer_unittest.cc
@@ -2,8 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/component_updater/cld_component_installer.h"
+
#include <stddef.h>
#include <stdint.h>
+#include <utility>
#include <vector>
#include "base/files/file_path.h"
@@ -15,7 +18,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "base/version.h"
-#include "chrome/browser/component_updater/cld_component_installer.h"
#include "components/translate/content/browser/browser_cld_data_provider.h"
#include "components/translate/content/common/cld_data_source.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -126,7 +128,7 @@ TEST_F(CldComponentInstallerTest, ComponentReady) {
scoped_ptr<base::DictionaryValue> manifest;
const base::FilePath install_dir(FILE_PATH_LITERAL("/foo"));
const base::Version version("1.2.3.4");
- traits_.ComponentReady(version, install_dir, manifest.Pass());
+ traits_.ComponentReady(version, install_dir, std::move(manifest));
base::FilePath result = CldComponentInstallerTraits::GetLatestCldDataFile();
ASSERT_TRUE(base::StartsWith(result.AsUTF16Unsafe(),
install_dir.AsUTF16Unsafe(),

Powered by Google App Engine
This is Rietveld 408576698