Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5230)

Unified Diff: chrome/browser/banners/app_banner_settings_helper.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_settings_helper.cc
diff --git a/chrome/browser/banners/app_banner_settings_helper.cc b/chrome/browser/banners/app_banner_settings_helper.cc
index e4e6755d3f37c46911ad305fd382c6fd5ee28c0b..5e456b741156cb8edba1521fba88cb8a10e7c06e 100644
--- a/chrome/browser/banners/app_banner_settings_helper.cc
+++ b/chrome/browser/banners/app_banner_settings_helper.cc
@@ -5,9 +5,9 @@
#include "chrome/browser/banners/app_banner_settings_helper.h"
#include <stddef.h>
-
#include <algorithm>
#include <string>
+#include <utility>
#include "base/command_line.h"
#include "base/strings/string_number_conversions.h"
@@ -336,7 +336,7 @@ void AppBannerSettingsHelper::RecordBannerCouldShowEvent(
scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
value->SetDouble(kBannerTimeKey, time.ToInternalValue());
value->SetDouble(kBannerEngagementKey, engagement);
- could_show_list->Append(value.Pass());
+ could_show_list->Append(std::move(value));
settings->SetWebsiteSettingDefaultScope(origin_url, GURL(),
CONTENT_SETTINGS_TYPE_APP_BANNER,

Powered by Google App Engine
This is Rietveld 408576698