Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_uma_util.h" 5 #include "chrome/browser/permissions/permission_uma_util.h"
6 6
7 #include <utility>
8
7 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
8 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
9 #include "chrome/browser/browser_process.h" 11 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/permissions/permission_manager.h" 12 #include "chrome/browser/permissions/permission_manager.h"
11 #include "chrome/browser/permissions/permission_util.h" 13 #include "chrome/browser/permissions/permission_util.h"
12 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
13 #include "components/rappor/rappor_service.h" 15 #include "components/rappor/rappor_service.h"
14 #include "components/rappor/rappor_utils.h" 16 #include "components/rappor/rappor_utils.h"
15 #include "content/public/browser/permission_type.h" 17 #include "content/public/browser/permission_type.h"
16 #include "content/public/common/origin_util.h" 18 #include "content/public/common/origin_util.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 scoped_ptr<rappor::Sample> sample = 177 scoped_ptr<rappor::Sample> sample =
176 rappor_service->CreateSample(rappor::SAFEBROWSING_RAPPOR_TYPE); 178 rappor_service->CreateSample(rappor::SAFEBROWSING_RAPPOR_TYPE);
177 sample->SetStringField("Scheme", requesting_origin.scheme()); 179 sample->SetStringField("Scheme", requesting_origin.scheme());
178 sample->SetStringField("Host", requesting_origin.host()); 180 sample->SetStringField("Host", requesting_origin.host());
179 sample->SetStringField("Port", requesting_origin.port()); 181 sample->SetStringField("Port", requesting_origin.port());
180 sample->SetStringField("Domain", 182 sample->SetStringField("Domain",
181 rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin)); 183 rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
182 sample->SetFlagsField("Actions", 184 sample->SetFlagsField("Actions",
183 1 << action, 185 1 << action,
184 PermissionAction::PERMISSION_ACTION_NUM); 186 PermissionAction::PERMISSION_ACTION_NUM);
185 rappor_service->RecordSampleObj("Permissions.Action." + 187 rappor_service->RecordSampleObj("Permissions.Action." + permission_str,
186 permission_str, sample.Pass()); 188 std::move(sample));
187 } 189 }
188 190
189 std::string PermissionTypeToString(PermissionType permission_type) { 191 std::string PermissionTypeToString(PermissionType permission_type) {
190 switch (permission_type) { 192 switch (permission_type) {
191 case PermissionType::MIDI_SYSEX: 193 case PermissionType::MIDI_SYSEX:
192 return "MidiSysex"; 194 return "MidiSysex";
193 case PermissionType::PUSH_MESSAGING: 195 case PermissionType::PUSH_MESSAGING:
194 return "PushMessaging"; 196 return "PushMessaging";
195 case PermissionType::NOTIFICATIONS: 197 case PermissionType::NOTIFICATIONS:
196 return "Notifications"; 198 return "Notifications";
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 298
297 void PermissionUmaUtil::PermissionDismissed(PermissionType permission, 299 void PermissionUmaUtil::PermissionDismissed(PermissionType permission,
298 const GURL& requesting_origin) { 300 const GURL& requesting_origin) {
299 RecordPermissionAction(permission, DISMISSED, requesting_origin); 301 RecordPermissionAction(permission, DISMISSED, requesting_origin);
300 } 302 }
301 303
302 void PermissionUmaUtil::PermissionIgnored(PermissionType permission, 304 void PermissionUmaUtil::PermissionIgnored(PermissionType permission,
303 const GURL& requesting_origin) { 305 const GURL& requesting_origin) {
304 RecordPermissionAction(permission, IGNORED, requesting_origin); 306 RecordPermissionAction(permission, IGNORED, requesting_origin);
305 } 307 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698