Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1551473002: [builtins] Fix context for ConstructStub calls into C++. (Closed)

Created:
4 years, 12 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix context for ConstructStub calls into C++. When calling into C++ for a ConstructStub, we need to enter the target context manually currently, which seems to be too fragile and easy to forget. So instead of doing that manually, we just always enter the correct context in the trampoline. Drive-by-fix: Trivial cleanups for some builtins. R=cbruni@chromium.org Committed: https://crrev.com/cf25c24110b054fb574e3a0562d988a0cc0b1465 Cr-Commit-Position: refs/heads/master@{#33051}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -18 lines) Patch
M src/arm/builtins-arm.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 6 chunks +2 lines, -16 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Benedikt Meurer
4 years, 12 months ago (2015-12-26 19:07:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551473002/1
4 years, 12 months ago (2015-12-26 19:17:19 UTC) #3
Benedikt Meurer
Hey Camillo, Simple fix and some cleanup. Please take a look. Thanks, Benedikt
4 years, 12 months ago (2015-12-26 19:17:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-26 19:52:17 UTC) #6
Camillo Bruni
lgtm
4 years, 12 months ago (2015-12-28 08:39:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551473002/1
4 years, 11 months ago (2015-12-28 19:30:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13601)
4 years, 11 months ago (2015-12-28 19:32:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551473002/20001
4 years, 11 months ago (2015-12-28 19:45:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-28 20:17:18 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2015-12-28 20:18:14 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf25c24110b054fb574e3a0562d988a0cc0b1465
Cr-Commit-Position: refs/heads/master@{#33051}

Powered by Google App Engine
This is Rietveld 408576698