Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1551453002: Stop disabling compiler warning 4481, v8 edition. (Closed)

Created:
4 years, 12 months ago by Nico
Modified:
4 years, 11 months ago
CC:
Lei Zhang, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stop disabling compiler warning 4481, v8 edition. Matches https://crrev.com/366832 BUG=none LOG=n Committed: https://crrev.com/e375ceaca470d2ef32a64281b6f6bbbe2e1e3aee Cr-Commit-Position: refs/heads/master@{#33182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/standalone.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 12 months ago (2015-12-25 22:57:17 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 11 months ago (2016-01-08 14:46:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551453002/1
4 years, 11 months ago (2016-01-08 14:58:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 15:21:28 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 15:22:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e375ceaca470d2ef32a64281b6f6bbbe2e1e3aee
Cr-Commit-Position: refs/heads/master@{#33182}

Powered by Google App Engine
This is Rietveld 408576698