Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1551333002: Use JSObjectVerify instead of trying to reimplement parts of it. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use JSObjectVerify instead of trying to reimplement parts of it. R=verwaest@chromium.org BUG=chromium:573857 LOG=n Committed: https://crrev.com/fed2c416dfb6f395e8e97ef95b2b0cce6bfeca81 Cr-Commit-Position: refs/heads/master@{#33083}

Patch Set 1 #

Patch Set 2 : Blacklist test for ignition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/objects-debug.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-573857.js View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-04 05:25:12 UTC) #1
Benedikt Meurer
Hey Toon, Easy fix to make clusterfuzz happy. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-04 05:27:57 UTC) #2
Toon Verwaest
lgtm
4 years, 11 months ago (2016-01-04 13:42:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551333002/20001
4 years, 11 months ago (2016-01-04 13:46:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 13:49:54 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 13:50:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fed2c416dfb6f395e8e97ef95b2b0cce6bfeca81
Cr-Commit-Position: refs/heads/master@{#33083}

Powered by Google App Engine
This is Rietveld 408576698