Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 155133: Windowed plugins like Flash would cause the hung plugin dialog to show up whe... (Closed)

Created:
11 years, 5 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Windowed plugins like Flash would cause the hung plugin dialog to show up when the print dialog was displayed. The proposed fix is to signal the modal dialog event which would ensure that the renderer and plugins both pump messages when the print dialog is displayed. This fixes http://code.google.com/p/chromium/issues/detail?id=13804 Bug=13804 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20243

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 8

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 2

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -50 lines) Patch
M chrome/browser/renderer_host/render_view_host.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 2 3 4 5 6 7 8 9 8 chunks +17 lines, -14 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_helper.h View 1 2 3 4 5 6 7 8 9 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_helper.cc View 1 2 3 4 5 6 7 8 9 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 3 4 5 6 7 8 9 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 4 5 6 7 8 9 4 chunks +13 lines, -9 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 5 6 7 8 9 2 chunks +44 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/renderer/mock_render_thread.h View 5 6 7 8 9 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/renderer/mock_render_thread.cc View 5 6 7 8 9 1 chunk +6 lines, -8 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 2 3 4 5 6 7 8 9 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ananta
11 years, 5 months ago (2009-07-07 10:31:46 UTC) #1
ananta
Adding jam.
11 years, 5 months ago (2009-07-07 11:22:08 UTC) #2
jam
lgtm http://codereview.chromium.org/155133/diff/1042/46 File chrome/browser/renderer_host/resource_message_filter.h (right): http://codereview.chromium.org/155133/diff/1042/46#newcode25 Line 25: #include "chrome/common/render_messages.h" don't include render_messages in headers, ...
11 years, 5 months ago (2009-07-07 18:10:31 UTC) #3
M-A Ruel
http://codereview.chromium.org/155133/diff/1042/48 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/155133/diff/1042/48#newcode757 Line 757: params.routing_id, It's kind of sad what we can't ...
11 years, 5 months ago (2009-07-07 18:17:42 UTC) #4
jam
http://codereview.chromium.org/155133/diff/1042/48 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/155133/diff/1042/48#newcode757 Line 757: params.routing_id, On 2009/07/07 18:17:42, Marc-Antoine Ruel wrote: > ...
11 years, 5 months ago (2009-07-07 18:24:43 UTC) #5
ananta
maruel, Based on John's comment regarding retrieving the routing id from the ipc message, I ...
11 years, 5 months ago (2009-07-07 18:35:28 UTC) #6
M-A Ruel
[-chromium-reviews] Could routing_id be used to remove host_window_id and deduce it browser-side? Note that it ...
11 years, 5 months ago (2009-07-07 18:46:54 UTC) #7
iyengar
I will look into this in a subsequent CL. Thanks Ananta On Tue, Jul 7, ...
11 years, 5 months ago (2009-07-07 19:00:22 UTC) #8
jam
http://codereview.chromium.org/155133/diff/1071/79 File chrome/common/render_messages_internal.h (right): http://codereview.chromium.org/155133/diff/1071/79#newcode1081 Line 1081: IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_ScriptedPrint, this should be a control message since ...
11 years, 5 months ago (2009-07-07 21:22:47 UTC) #9
ananta
http://codereview.chromium.org/155133/diff/1071/79 File chrome/common/render_messages_internal.h (right): http://codereview.chromium.org/155133/diff/1071/79#newcode1081 Line 1081: IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_ScriptedPrint, On 2009/07/07 21:22:47, John Abd-El-Malek wrote: > ...
11 years, 5 months ago (2009-07-08 01:54:44 UTC) #10
ananta
11 years, 5 months ago (2009-07-08 01:56:16 UTC) #11
The ViewHostMsg_ScriptedPrint has been changed to a control message.

Powered by Google App Engine
This is Rietveld 408576698