Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1551313002: Enable -Wformat in linux, android, chromeos, cast builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | tools/android/file_poller/file_poller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 945 matching lines...) Expand 10 before | Expand all | Expand 10 after
956 956
957 if (is_clang) { 957 if (is_clang) {
958 cflags += [ 958 cflags += [
959 # Lots of third-party libraries have unused variables. Instead of 959 # Lots of third-party libraries have unused variables. Instead of
960 # suppressing them individually, we just blanket suppress them here. 960 # suppressing them individually, we just blanket suppress them here.
961 "-Wno-unused-variable", 961 "-Wno-unused-variable",
962 ] 962 ]
963 } 963 }
964 964
965 if (is_linux || is_android) { 965 if (is_linux || is_android) {
966 cflags += [
967 # Don't warn about printf format problems. This is off by default in gcc
968 # but on in Ubuntu's gcc(!).
969 "-Wno-format",
970 ]
971 cflags_cc += [ 966 cflags_cc += [
972 # Don't warn about hash_map in third-party code. 967 # Don't warn about hash_map in third-party code.
973 "-Wno-deprecated", 968 "-Wno-deprecated",
974 ] 969 ]
975 } 970 }
976 971
977 configs = [ ":default_warnings" ] 972 configs = [ ":default_warnings" ]
978 } 973 }
979 974
980 # rtti ------------------------------------------------------------------------ 975 # rtti ------------------------------------------------------------------------
(...skipping 326 matching lines...) Expand 10 before | Expand all | Expand 10 after
1307 if (symbol_level == 0) { 1302 if (symbol_level == 0) {
1308 configs = [ ":no_symbols" ] 1303 configs = [ ":no_symbols" ]
1309 } else if (symbol_level == 1) { 1304 } else if (symbol_level == 1) {
1310 configs = [ ":minimal_symbols" ] 1305 configs = [ ":minimal_symbols" ]
1311 } else if (symbol_level == 2) { 1306 } else if (symbol_level == 2) {
1312 configs = [ ":symbols" ] 1307 configs = [ ":symbols" ]
1313 } else { 1308 } else {
1314 assert(false) 1309 assert(false)
1315 } 1310 }
1316 } 1311 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | tools/android/file_poller/file_poller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698