Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/sqlite/sqlite.gyp

Issue 1551253002: ios: -Werror for third-party (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sqlite Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/class-dump/class-dump.gyp ('K') | « third_party/class-dump/class-dump.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sqlite/sqlite.gyp
diff --git a/third_party/sqlite/sqlite.gyp b/third_party/sqlite/sqlite.gyp
index db9df69169d62c18d1ea59e9b17bae9a6afeb9c0..63072dc66052bdef2c528416d2bef4d3dbd24392 100644
--- a/third_party/sqlite/sqlite.gyp
+++ b/third_party/sqlite/sqlite.gyp
@@ -243,6 +243,12 @@
'sources': [
'src/ext/icu/icu.c',
],
+ 'variables': {
+ 'clang_warning_flags_unset': [
+ # icu.c uses assert(!"foo") instead of assert(false && "foo")
+ '-Wstring-conversion',
+ ],
Nico 2016/01/04 20:15:10 This change already was present in the gn version,
+ },
},
],
}],
« third_party/class-dump/class-dump.gyp ('K') | « third_party/class-dump/class-dump.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698