Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 1551253002: ios: -Werror for third-party (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sqlite Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/class-dump/class-dump.gyp » ('j') | third_party/class-dump/class-dump.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index cbea95780ec9259301466486890457d51b26eb90..8a1cca714876bf24d63c595ca9913750e76f5bde 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3219,10 +3219,6 @@
}],
[ 'OS=="ios"', {
'xcode_settings': {
- # TODO(ios): Fix remaining warnings in third-party code, then
- # remove this; the Mac cleanup didn't get everything that's
- # flagged in an iOS build.
- 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
Nico 2016/01/04 20:15:10 This hasn't made it into the gn port of the iOS bu
'RUN_CLANG_STATIC_ANALYZER': 'NO',
# Several internal ios directories generate numerous warnings for
# -Wobjc-missing-property-synthesis.
« no previous file with comments | « no previous file | third_party/class-dump/class-dump.gyp » ('j') | third_party/class-dump/class-dump.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698