Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1551163002: Build fix for Pass()→std::move() conversion in EncryptedMediaTestBase (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build fix for Pass()→std::move() conversion in EncryptedMediaTestBase Official builds compile a different block of code. BUG=557422, 573354 TBR=dalecurtis@chromium.org Committed: https://crrev.com/7c133ccbe8c8eafbce97581f6ba526838727fdeb Cr-Commit-Position: refs/heads/master@{#367236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dcheng
A blind fix, since official builds take forever.
4 years, 11 months ago (2015-12-31 06:19:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551163002/1
4 years, 11 months ago (2015-12-31 06:19:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551163002/1
4 years, 11 months ago (2015-12-31 06:21:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 06:58:10 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 06:59:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c133ccbe8c8eafbce97581f6ba526838727fdeb
Cr-Commit-Position: refs/heads/master@{#367236}

Powered by Google App Engine
This is Rietveld 408576698