Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1551103002: Convert Pass()→std::move() in //media (Android Cast edition) (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //media (Android Cast edition) (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=ddorwin@chromium.org Committed: https://crrev.com/c0ff578b1202e001aa01c393700c40ab82dba461 Cr-Commit-Position: refs/heads/master@{#367193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -59 lines) Patch
M media/base/android/media_codec_decoder_unittest.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M media/base/android/media_codec_player.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M media/base/android/media_codec_player_unittest.cc View 17 chunks +35 lines, -31 lines 0 comments Download
M media/base/android/media_codec_video_decoder.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/base/android/media_drm_bridge.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M media/base/android/media_player_bridge.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M media/base/android/media_source_player.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/android/video_decoder_job.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/capture/video/android/video_capture_device_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/capture/video/android/video_capture_device_factory_android.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
4 years, 11 months ago (2015-12-30 20:36:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551103002/1
4 years, 11 months ago (2015-12-30 20:37:33 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 11 months ago (2015-12-30 20:43:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 22:03:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551103002/1
4 years, 11 months ago (2015-12-30 22:04:34 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 22:09:35 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 22:11:16 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c0ff578b1202e001aa01c393700c40ab82dba461
Cr-Commit-Position: refs/heads/master@{#367193}

Powered by Google App Engine
This is Rietveld 408576698