Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: third_party/tcmalloc/chromium/src/deep-heap-profile.cc

Issue 15511005: Breakdown "unhooked" memory regions by VMA pathnames and permissions. (Closed) Base URL: git@github.com:dmikurube/chromium.git@work
Patch Set: addressed bulach's comment Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/deep_memory_profiler/dmprof.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/tcmalloc/chromium/src/deep-heap-profile.cc
diff --git a/third_party/tcmalloc/chromium/src/deep-heap-profile.cc b/third_party/tcmalloc/chromium/src/deep-heap-profile.cc
index b5d482177043e4b1071af1f164dd0237f3e9cca9..5e589415c40b3f87d2785fd13c8e05929211b74d 100644
--- a/third_party/tcmalloc/chromium/src/deep-heap-profile.cc
+++ b/third_party/tcmalloc/chromium/src/deep-heap-profile.cc
@@ -41,15 +41,6 @@ static const char kProcSelfMapsHeader[] = "\nMAPPED_LIBRARIES:\n";
static const char kVirtualLabel[] = "virtual";
static const char kCommittedLabel[] = "committed";
-const char* DeepHeapProfile::kMapsRegionTypeDict[] = {
- "absent",
- "anonymous",
- "file-exec",
- "file-nonexec",
- "stack",
- "other",
-};
-
namespace {
#if defined(__linux__)
@@ -767,8 +758,6 @@ void DeepHeapProfile::GlobalStats::SnapshotMaps(
mmap_dump_buffer->AppendString(" - ", 0);
mmap_dump_buffer->AppendPtr(last_address_of_unhooked + 1, 0);
mmap_dump_buffer->AppendString(" unhooked ", 0);
- mmap_dump_buffer->AppendString(kMapsRegionTypeDict[type], 0);
- mmap_dump_buffer->AppendString(" ", 0);
mmap_dump_buffer->AppendInt64(committed_size, 0);
mmap_dump_buffer->AppendString(" / ", 0);
mmap_dump_buffer->AppendInt64(
@@ -802,8 +791,6 @@ void DeepHeapProfile::GlobalStats::SnapshotMaps(
mmap_dump_buffer->AppendPtr(mmap_iter->end_addr, 0);
mmap_dump_buffer->AppendString(continued ? ")" : " ", 0);
mmap_dump_buffer->AppendString(" hooked ", 0);
- mmap_dump_buffer->AppendString(kMapsRegionTypeDict[type], 0);
- mmap_dump_buffer->AppendString(" ", 0);
mmap_dump_buffer->AppendInt64(committed_size, 0);
mmap_dump_buffer->AppendString(" / ", 0);
mmap_dump_buffer->AppendInt64(
« no previous file with comments | « no previous file | tools/deep_memory_profiler/dmprof.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698