Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1551093002: GN: Set arm_float_abi when target_cpu = "arm64" (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Set arm_float_abi when target_cpu = "arm64" Fixes gn gen failure: Generating files... ERROR at //third_party/ffmpeg/BUILD.gn:199:11: Undefined identifier if (arm_float_abi == "hard") { ^------------ BUG=568883 Committed: https://crrev.com/03301146b8d58e6f2e82b60f7df511be646f59a9 Cr-Commit-Position: refs/heads/master@{#367615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/config/arm.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
agrieve
On 2015/12/30 19:16:59, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:dpranke@chromium.org ☣
4 years, 11 months ago (2015-12-30 19:17:35 UTC) #3
brettw
lgtm
4 years, 11 months ago (2016-01-05 18:04:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551093002/1
4 years, 11 months ago (2016-01-05 18:37:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 19:45:47 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/03301146b8d58e6f2e82b60f7df511be646f59a9 Cr-Commit-Position: refs/heads/master@{#367615}
4 years, 11 months ago (2016-01-05 19:46:29 UTC) #11
Dirk Pranke
4 years, 11 months ago (2016-01-20 18:57:44 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698