chrome/browser/password_manager/save_password_infobar_delegate.cc - Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.cc

Issue 1551033002: Convert Pass()→std::move() in //chrome (Android edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable RVO by making types match Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_factory.cc ('k') | chrome/browser/password_manager/save_password_infobar_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/save_password_infobar_delegate.cc

diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.cc b/chrome/browser/password_manager/save_password_infobar_delegate.cc

index 6a831b9509ff8aea716352ab227a35d673c01f31..2ad6ed3e3fa287e8592e6c09f8fb641a90a4548c 100644

--- a/chrome/browser/password_manager/save_password_infobar_delegate.cc

+++ b/chrome/browser/password_manager/save_password_infobar_delegate.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/password_manager/save_password_infobar_delegate.h"

+#include <utility>

#include "base/metrics/histogram.h"

#include "chrome/browser/infobars/infobar_service.h"

#include "chrome/browser/profiles/profile.h"

@@ -45,7 +47,7 @@ void SavePasswordInfoBarDelegate::Create(

InfoBarService::FromWebContents(web_contents)

->AddInfoBar(CreateSavePasswordInfoBar(

make_scoped_ptr(new SavePasswordInfoBarDelegate(

- web_contents, form_to_save.Pass(), uma_histogram_suffix,

+ web_contents, std::move(form_to_save), uma_histogram_suffix,

source_type, is_smartlock_branding_enabled,

should_show_first_run_experience))));

}

@@ -89,7 +91,7 @@ SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(

bool is_smartlock_branding_enabled,

bool should_show_first_run_experience)

: PasswordManagerInfoBarDelegate(),

- form_to_save_(form_to_save.Pass()),

+ form_to_save_(std::move(form_to_save)),

infobar_response_(password_manager::metrics_util::NO_RESPONSE),

uma_histogram_suffix_(uma_histogram_suffix),

source_type_(source_type),